-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Split VirtualViewContainerState into classic, experimental versions [Android] #54162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+390
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@CalixTang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84569206. |
CalixTang
added a commit
to CalixTang/react-native
that referenced
this pull request
Oct 17, 2025
…Android] (facebook#54162) Summary: Pull Request resolved: facebook#54162 Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now. Reviewed By: lunaleaps Differential Revision: D84569206
5ee070e
to
007377b
Compare
CalixTang
added a commit
to CalixTang/react-native
that referenced
this pull request
Oct 20, 2025
…Android] (facebook#54162) Summary: Pull Request resolved: facebook#54162 Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now. Reviewed By: lunaleaps Differential Revision: D84569206
007377b
to
b6d9b3d
Compare
Summary: Introduces new React Native feature flag for VirtualViewContainerState versioning changes. Follow up diffs will create classic and experimental versions of VirtualViewContainerState. This feature flag is meant to eventually be overridden with MetaConfig variables. Differential Revision: D84569199
Summary: Removes unnecessary `debugLog` import in ReactVirtualViewExperimental and refactors the debug function Differential Revision: D84608555
CalixTang
added a commit
to CalixTang/react-native
that referenced
this pull request
Oct 20, 2025
…Android] (facebook#54162) Summary: Pull Request resolved: facebook#54162 Changelog [Internal]: Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now. Reviewed By: lunaleaps Differential Revision: D84569206
b6d9b3d
to
565c15f
Compare
CalixTang
added a commit
to CalixTang/react-native
that referenced
this pull request
Oct 20, 2025
…Android] (facebook#54162) Summary: Pull Request resolved: facebook#54162 Changelog [Internal]: Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now. Reviewed By: lunaleaps Differential Revision: D84569206
565c15f
to
3c8b03a
Compare
CalixTang
added a commit
to CalixTang/react-native
that referenced
this pull request
Oct 20, 2025
…Android] (facebook#54162) Summary: Pull Request resolved: facebook#54162 Changelog [Internal]: Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now. Reviewed By: lunaleaps Differential Revision: D84569206
3c8b03a
to
e86a3d5
Compare
…Android] (facebook#54162) Summary: Pull Request resolved: facebook#54162 Changelog [Internal]: Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now. Reviewed By: lunaleaps Differential Revision: D84569206
e86a3d5
to
4c7766c
Compare
This pull request has been merged in 793f99d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Splits VirtualViewContainerState implementation into three parts: (1) an abstract parent class, (2) the "classic" version (existing version), and (3) the "experimental" version (new changes to be made). The experimental version is a copy of the classic version for now.
Reviewed By: lunaleaps
Differential Revision: D84569206