VirtualView: Create Activity Experiment #53488
Closed
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Creates a new feature flag to experiment with `Activity` in `VirtualView`. The feature flag enables the following treatments: - `no-activity` is the same as what we currently do — no `Activity` and we render `null` for hidden elements. - `activity-without-mode` wraps the children in `Activity` but does not set `mode` and still renders `null` for hidden elements. - `activity-with-hidden-mode` wraps the children in `Activity` and sets `mode="hidden"` and continues providing `children` (not `null`) for hidden elements. Changelog: [Internal] Reviewed By: rickhanlonii Differential Revision: D81149561
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81149561 |
|
This pull request has been merged in 72158fc. |
|
This pull request was successfully merged by @yungsters in 72158fc When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Creates a new feature flag to experiment with
ActivityinVirtualView.The feature flag enables the following treatments:
no-activityis the same as what we currently do — noActivityand we rendernullfor hidden elements.activity-without-modewraps the children inActivitybut does not setmodeand still rendersnullfor hidden elements.activity-with-hidden-modewraps the children inActivityand setsmode="hidden"and continues providingchildren(notnull) for hidden elements.Changelog:
[Internal]
Reviewed By: rickhanlonii
Differential Revision: D81149561