Skip to content

Require error code in suppressions, and kill $FlowIssue and $FlowIgnore in react-native #53487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Require error code in suppressions, and kill $FlowIssue and $FlowIgnore in react-native #53487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ module.system.haste.module_ref_prefix=m#

react.runtime=automatic

experimental.error_code_migration=new
experimental.only_support_flow_fixme_and_expected_error=true
experimental.require_suppression_with_error_code=true

ban_spread_key_props=true

Expand Down
2 changes: 1 addition & 1 deletion packages/debugger-shell/src/node/index.flow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ function getShellBinaryAndArgs(
switch (flavor) {
case 'prebuilt':
return [
// $FlowIssue[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
// $FlowFixMe[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
require('fb-dotslash'),
[DEVTOOLS_BINARY_DOTSLASH_FILE],
];
Expand Down
2 changes: 1 addition & 1 deletion packages/debugger-shell/src/node/private/LaunchUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async function prepareDebuggerShellFromDotSlashFile(
filePath: string,
): Promise<DebuggerShellPreparationResult> {
const {code, stderr} = await spawnAndGetStderr(
// $FlowIssue[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
// $FlowFixMe[cannot-resolve-module] fb-dotslash includes Flow types but Flow does not pick them up
require('fb-dotslash'),
['--', 'fetch', filePath],
);
Expand Down
Loading