Properly set REACTNATIVE_MERGED_SO for autolinked libraries.
#46606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This fixes this issue reported here: react-native-community/discussions-and-proposals#816 (reply in thread) reported by both SWM and Expo. The problem is that `REACTNATIVE_MERGED_SO` is not properly set for autolinked libraries so they can't access it to understand if the version of ReactNative has merged so libraries or not. This fixes it, I've tested against https://github.com/tomekzaw/repro-reactnative-merged-so reproducer provided by tomekzaw Changelog: [Android] [Fixed] - Properly set `REACTNATIVE_MERGED_SO` for autolinked libraries Differential Revision: D63262687
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63262687 |
|
This pull request has been merged in c005609. |
|
This pull request was successfully merged by @cortinico in c005609 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: #46606 This fixes this issue reported here: react-native-community/discussions-and-proposals#816 (reply in thread) reported by both SWM and Expo. The problem is that `REACTNATIVE_MERGED_SO` is not properly set for autolinked libraries so they can't access it to understand if the version of ReactNative has merged so libraries or not. This fixes it, I've tested against https://github.com/tomekzaw/repro-reactnative-merged-so reproducer provided by tomekzaw Changelog: [Android] [Fixed] - Properly set `REACTNATIVE_MERGED_SO` for autolinked libraries Reviewed By: rubennorte Differential Revision: D63262687 fbshipit-source-id: c505dce9036bb4cd0366b7ab99412368963273af
|
This pull request was successfully merged by @cortinico in cffeb60 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes this issue reported here:
react-native-community/discussions-and-proposals#816 (reply in thread)
reported by both SWM and Expo.
The problem is that
REACTNATIVE_MERGED_SOis not properly set for autolinked libraries so they can't access itto understand if the version of ReactNative has merged so libraries or not.
This fixes it, I've tested against
https://github.com/tomekzaw/repro-reactnative-merged-so
reproducer provided by @tomekzaw
Changelog:
[Android] [Fixed] - Properly set
REACTNATIVE_MERGED_SOfor autolinked librariesDifferential Revision: D63262687