Using UIManagerProvider instead of JSIModule in UIManagerHelper #41738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51719040 |
Base commit: f941f93 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
Summary: Replacing the callsite to `context.getFabricUIManager()` in UIManagerHelper instead of `getJSIModule()` Reviewed By: philIip Differential Revision: D51719040
Summary: Replacing the callsite to `context.getFabricUIManager()` in UIManagerHelper instead of `getJSIModule()` Reviewed By: philIip Differential Revision: D51719040
|
This pull request was exported from Phabricator. Differential Revision: D51719040 |
arushikesarwani94
force-pushed
the
export-D51719040
branch
from
17f890f to
80696ef
Compare
arushikesarwani94
added a commit
that referenced
this pull request
Dec 1, 2023
Summary: Replacing the callsite to `context.getFabricUIManager()` in UIManagerHelper instead of `getJSIModule()` Fixing the crash by directly making `getFabricUIManager()` of `ReactContext` independent of the assertion. Reviewed By: philIip Differential Revision: D51719040
|
This pull request has been merged in 75019c8. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…book#41738) Summary: Pull Request resolved: facebook#41738 Replacing the callsite to `context.getFabricUIManager()` in UIManagerHelper instead of `getJSIModule()` Fixing the crash by directly making `getFabricUIManager()` of `ReactContext` independent of the assertion. Reviewed By: philIip Differential Revision: D51719040 fbshipit-source-id: f9118b16614724a1d6dabe59d5c4d25dd4bdbc73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replacing the callsite to
context.getFabricUIManager()in UIManagerHelper instead ofgetJSIModule()Reviewed By: philIip
Differential Revision: D51719040