Skip to content

Add viewIsDescendantOf for UIManager on Android #13129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add viewIsDescendantOf for UIManager on Android #13129

wants to merge 3 commits into from

Conversation

@Swordsman-Inaction
Copy link
Contributor

Add the ability for UIManager to check if a node is an ancestor of anther one on Android like #7876 did on iOS

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Mar 24, 2017
@Swordsman-Inaction
Copy link
Contributor Author

Any one to review this PR?

@Swordsman-Inaction
Copy link
Contributor Author

@janicduplessis Do you know who can review this PR?

janicduplessis
janicduplessis suggested changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @mkonicek could you also have a look?

ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java
/**
* Check if the first shadow node is the descendant of the second shadow node
*/
public void viewIsDescendantOf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 4 space continuation to match the style of the file.

ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java
* Check if the first shadow node is the descendant of the second shadow node
*/
@ReactMethod
public void viewIsDescendantOf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Same here

@Swordsman-Inaction
Copy link
Contributor Author

@mkonicek Can you review?

@Swordsman-Inaction Swordsman-Inaction mentioned this pull request Apr 11, 2017
Closed
@Swordsman-Inaction
Copy link
Contributor Author

@janicduplessis Hey, I must say the review progress is very slow.

@ms88privat
Copy link

Please :)

@janicduplessis
Copy link
Contributor

@Swordsman-Inaction Sorry about the delay, can you rebase on master to get tests passing then I'll merge.

@Swordsman-Inaction
Copy link
Contributor Author

@janicduplessis Done

@janicduplessis
Copy link
Contributor

@facebook-github-bot shipit

@Swordsman-Inaction
Copy link
Contributor Author

Something is wrong with the github bot?

@janicduplessis
Copy link
Contributor

@facebook-github-bot shipit

@janicduplessis
Copy link
Contributor

@hramos Could you try shipping this

@hramos
Copy link
Contributor

hramos commented Apr 27, 2017

Will do - let me first see if we can troubleshoot why the bot didn't work on this PR.

@Swordsman-Inaction
Copy link
Contributor Author

@hramos Still not work?
It doesn't work since April 25.

image

I thought I could make this available in 0.44. 😞

@ericnakagawa
Copy link
Contributor

Trying to land this today.

@Swordsman-Inaction
Copy link
Contributor Author

Any update?

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 23, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Swordsman-Inaction Swordsman-Inaction mentioned this pull request Jun 6, 2017
Closed
@alvaromb alvaromb mentioned this pull request Jun 6, 2017
Closed
@koubaabdellah koubaabdellah mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@janicduplessis janicduplessis janicduplessis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Swordsman-Inaction @ms88privat @janicduplessis @hramos @ericnakagawa @facebook-github-bot