Skip to content

Conversation

guangli-dai
Copy link

@guangli-dai guangli-dai commented Oct 8, 2025

Two changes in this PR:

  1. refactor so that init_system_thp_mode uses a different enum value. This is because thp_mode_t is designed for option opt.thp, which is not accurate: 0 should be "madvise" instead of "default". Besides, once HPA settles down, users should use HPA instead of PAC + opt.thp:always. This refactoring makes future removal easier and cleaner.
  2. Export init_system_thp_mode value to stats. HPA interferes with kernel's THP settings and exporting it to stats help users understand the system better.

Updated malloc stats have a new section as below:

...
  config.xmalloc: false
System configuration
  system.thp_mode: "madvise"
Run-time option settings
...

@meta-cla meta-cla bot added the cla signed label Oct 8, 2025
@guangli-dai guangli-dai force-pushed the system_thp branch 2 times, most recently from 2051ef2 to 09d6470 Compare October 12, 2025 00:41
@guangli-dai guangli-dai marked this pull request as ready for review October 12, 2025 07:20
@guangli-dai guangli-dai merged commit 0f8a8d7 into facebook:dev Oct 13, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants