Refactor init_system_thp_mode and print it in malloc stats. #49
+63
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes in this PR:
init_system_thp_mode
uses a different enum value. This is becausethp_mode_t
is designed for optionopt.thp
, which is not accurate: 0 should be "madvise" instead of "default". Besides, once HPA settles down, users should use HPA instead of PAC +opt.thp:always
. This refactoring makes future removal easier and cleaner.init_system_thp_mode
value to stats. HPA interferes with kernel's THP settings and exporting it to stats help users understand the system better.Updated malloc stats have a new section as below: