Skip to content

Conversation

@Bnaya
Copy link

@Bnaya Bnaya commented Oct 27, 2018

this is a possible fix
Corrent link is leading to:
https://facebook.github.io/docs/deployment#building-for-relative-paths [broken]
And not to:
https://facebook.github.io/create-react-app/docs/deployment#building-for-relative-paths [good]

Not how to make it work also inside GH, as the .md file ext is missing and not added by default (?)

this is a possible fix
Corrent link is leading to:
https://facebook.github.io/docs/deployment#building-for-relative-paths [broken]
And not to:
https://facebook.github.io/create-react-app/docs/deployment#building-for-relative-paths [good]

Not how to make it work also inside GH, as the .md file ext is missing and not added by default (?)
@ehfeng
Copy link
Contributor

ehfeng commented Oct 29, 2018

I've opened a larger PR around this here: #5552

@Bnaya Bnaya closed this Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants