Updated the link to firebase hosting #5348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firebase link was targeting Firebase JS SDK which is not correct for this part of the documentation. This section of the documentation is trying to outline various deployment methods, Firebase JS SDK has nothing to do with deployment. Instead, the link should be pointing to Firebase Hosting Docs.
Contributor
|
We've since moved to Docusaurus. Do you mind updating https://github.com/facebook/create-react-app/blob/master/docusaurus/docs/deployment.md instead? |
Contributor
Author
|
For sure, I am closing this PR and creating a new one: #5710 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase link was targeting Firebase JS SDK which is not correct for this part of the documentation. This section of the documentation is trying to outline various deployment methods, Firebase JS SDK has nothing to do with deployment. Instead, the link should be pointing to Firebase Hosting Docs.