Proposal for representing static children and selectively avoid React warnings #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling in createElement
… property extraction
|
Hello @Canna71 ! We are currently restructuring Feliz for a v3.0.0 release. This release will shift Feliz to output JSX syntax which will circumvent the issue of static/dynamic children and handle them correctly! I will add a module/docs guide for people who still want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at solving the issue of not currently having a way to distinguish a static list of children from a dynamic one (e.g. a List.map).
Any solution that suppresses React warnings for lists without key is IMHO bad and it would be better to provide a way to express a static list of children; this should not be the default and using it will be a conscious choice, so we will never hide the warnings to the developers so they will realize when they missed to pass the keys.
More details and the logic behind it are in the discussion of the Issue #21