-
Notifications
You must be signed in to change notification settings - Fork 58
Components | Sankey: Zoom / Pan, Node selection, Better label rendering, and more #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rokotyan
wants to merge
17
commits into
f5:main
Choose a base branch
from
rokotyan:feature/sankey-zoom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code for the Zoom / Pan feature has been LLM-generated and was over-engineered in my opinion. This commit makes he code simple and more compact: - Rename and pack some of the variables - Scale vertically from the topmost node - Allow specifying yTolerance for `labelMaxWidthTakeAvailableSpace` - Cache bleed calculations because they are expensive
|
The initial |
|
Note: This update will go in 1.7 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Screen.Recording.2025-10-13.at.2.04.58.PM.mp4
This PR implements several new Sankey features:
Interactive Zoom / Pan
Zoom happens by scaling the layout, not by rescaling the SVG elements.
New configuration properties
zoomScale: [number, number]- Horizontal and vertical scale factors applied to the layoutzoomPan: [number, number]- Pan offset in pixelsenableZoom: boolean- Toggle interactive zoom/pan behavior (default:true)zoomExtent: [number, number]- Allowed interactive zoom scale extent (default:[1, 5])zoomMode: SankeyZoomMode- Zoom interaction mode: XY, X, or Y (default: Y)onZoom- Zoom event callbackAutomatic Label Sizing
Smart Label Width Calculation
labelMaxWidthTakeAvailableSpace: boolean- Enable automatic label width calculation (default:false)labelMaxWidthTakeAvailableSpaceTolerance: number- Tolerance for space calculation (defaults to label and sub-label font sizes)Node Selection State
selectedNodeIds: string[]config to programmatically set selected nodesLabel Text Decoration
labelTextDecoration: StringAccessor<SankeyNode<N, L>>- Custom text decoration for main labels (underline, line-through, etc.)subLabelTextDecoration: StringAccessor<SankeyNode<N, L>>- Custom text decoration for sub-labelsMisc
bleedvalues for better performanceTodo: