Skip to content

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Feb 13, 2020

  • so remove that reference to objectHashIgnoreUnknownHack

  • also be more specific about what cases objectHashIgnoreUnknownHack
    might be needed for

    • asyncgeneratorfunctions are still one off the top of my head, but
      there are certainly others it just won't know about, including
      future syntaxes

Follow-up to #203 . Sorry probably should've changed the docs in the same go as that fix, but was moving too fast and didn't quite think about it until after. This I found while incidentally reading the docs for something else.

- so remove that reference to objectHashIgnoreUnknownHack

- also be more specific about what cases objectHashIgnoreUnknownHack
  might be needed for
  - asyncgeneratorfunctions are still one off the top of my head, but
    there are certainly others it just won't know about, including
    future syntaxes
@ezolenko ezolenko merged commit 0caa1c4 into ezolenko:master Feb 13, 2020
@agilgur5 agilgur5 added the scope: docs Documentation could be improved. Or changes that only affect docs label May 7, 2022
Repository owner locked as resolved and limited conversation to collaborators May 7, 2022
@agilgur5 agilgur5 added the kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc label Jul 22, 2022
@agilgur5 agilgur5 deleted the fix-docs-async branch July 2, 2023 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind: dx Improvements to dev experience, e.g. error messages, logging, external-facing docs, etc scope: docs Documentation could be improved. Or changes that only affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants