Imported helper support requires `"moduleResolution": "node"` in tsconfig

[ezolenko]

Otherwise typescript can't find tslib in local node_modules. (see #12)

Running tsc without that option works, so there must be a better way of finding tslib than using require.resolve.

[ezolenko]

microsoft/TypeScript#14468
s-panferov/awesome-typescript-loader#250

[vardius]

Any solutions for this one ? My build with rollup works, but then when I am using my lib in node projects i get this error: Cannot find module 'tslib' from 'bundle.js'

[ezolenko]

That shouldn't happen... Did you set tslib as an external dependency in rollup config?

What's you rollup / typescript versions and what does top of your transpiled bundle look like? Does it have import/require tslib?

[vardius]

I have var tslib_1 = require("tslib");

Versions:

    "rollup": "^0.43.0",
    "tslib": "^1.7.1",
    "tslint": "^5.4.3",
    "typescript": "^2.4.1"

and my config is:

{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "rootDir": "src",
    "outDir": ".code",
    "newLine": "LF",
    "lib": [
      "es2015",
      "es2016",
      "es2017",
      "dom",
      "scripthost"
    ],
    "moduleResolution": "node",
    "importHelpers": true,
    "declaration": true,
    "pretty": true,
    "sourceMap": true,
    "inlineSources": true,
    "noUnusedLocals": true,
    "skipLibCheck": true
  },
  "include": [
    "src/**/*"
  ],
  "exclude": [
    "node_modules",
    "**/*.spec.ts",
    "dist",
    "es",
    "lib"
  ]
}

[ezolenko]

What your rollup config look like?

Also, try with "rollup-plugin-typescript2": "github:ezolenko/rollup-plugin-typescript2#master" instead of 0.4.4 -- I just (hopefully) fixed a bug related to typescript 2.4.1.

[vardius]

  moduleName: pascalCase(pkg.name),
  entry: "src/index.ts",
  dest: "dist/bundle.js",
  format: "umd",
  exports: "named",
  sourceMap: true,
  plugins: [
    typescript(),
    sourcemaps(),
    resolve({
      jsnext: true,
      browser: true
    }),
    commonjs(),
    globals(),
    builtins(),
    uglify()
  ]

[ezolenko]

Could you run the build with typescript({ clean: true, verbosity: 3 }), (on master branch) and post the output?

Also post your package config (the part with all the rollup plugins).

It is possible one of those plugins clobbers tslib resolution and it doesn't get replaced by this plugin...

[vardius]

With the master branch it does work. Could you release it ?

[ezolenko]

Cool, I'll release later today.

[ezolenko]

Back to original bug, reading typescript documentation it seems classic resolution is mostly for backwards compatibility anyway, so closing as won't fix.