Skip to content

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Sep 26, 2024

This improves the extism-js install experience a bit:

  • removes the hard coded TAG variable and fetches the latest tag from github api
  • tries to install extism-js in a local bin before it asks for sudo and tries a system directory
  • is a little more chatty about what it's doing and tells you when it's done and how to verify

Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment about the shebang and set -e line out of paranoia

bhelx and others added 2 commits September 26, 2024 15:50
@bhelx bhelx force-pushed the update-install-script-2 branch from ba85b7c to 0c975f7 Compare September 26, 2024 21:04
@bhelx bhelx merged commit 6be117b into main Sep 26, 2024
8 checks passed
@bhelx bhelx deleted the update-install-script-2 branch September 26, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants