Skip to content

Conversation

ShubhamOulkar
Copy link
Member

same as title

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner August 24, 2025 04:15
Copy link

netlify bot commented Aug 24, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 345d22a
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/68aaa2d33aedc6000816db68
😎 Deploy Preview https://deploy-preview-2048--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

github-actions bot commented Aug 24, 2025

🚦 Lighthouse Results (Mobile & Desktop)

URL Device Perf A11y Best Practices
/ mobile 🔴 70 🟢 100 🟢 96
/en/blog/posts.html mobile 🟠 89 🟢 96 🟢 96
/en/5x/api.html mobile 🔴 74 🟢 95 🟢 96
/ desktop 🟢 100 🟢 100 🟢 96
/en/blog/posts.html desktop 🟢 97 🟢 96 🟢 93
/en/5x/api.html desktop 🟢 97 🟢 95 🟢 96

@ShubhamOulkar ShubhamOulkar enabled auto-merge (squash) August 26, 2025 15:15
@bjohansebas bjohansebas requested a review from Copilot August 31, 2025 01:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the CI workflow by adding logic to skip Lighthouse audits when Netlify preview deployments are not available, preventing failed CI runs due to unavailable preview URLs.

  • Increases retry attempts from 4 to 12 with configurable delay
  • Sets environment variable to conditionally skip Lighthouse steps when preview is unavailable
  • Adds conditional execution to all Lighthouse-related workflow steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay. I’m trying to prioritize my OSS work now that I have a new university schedule. I’ll try to review the PRs on weekends.

@ShubhamOulkar ShubhamOulkar merged commit 4106a90 into expressjs:gh-pages Aug 31, 2025
12 checks passed
@ShubhamOulkar ShubhamOulkar deleted the update-lighthouse branch August 31, 2025 02:16
@ShubhamOulkar
Copy link
Member Author

LGTM, sorry for the delay. I’m trying to prioritize my OSS work now that I have a new university schedule. I’ll try to review the PRs on weekends.

It is better late than nothing. I am also doing on weekends 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants