Skip to content

Refactor firstchar function for conciseness and modern syntax #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor firstchar function for conciseness and modern syntax #555

wants to merge 1 commit into from

Conversation

Ayoub-Mabrouk
Copy link

  • Replaced var with const for improved variable management
  • Used optional chaining for a more concise return statement
  • Enhanced readability while preserving functionality

@Ayoub-Mabrouk
Refactor firstchar function for conciseness and modern syntax
aec6065 
- Replaced var with const for improved variable management
- Used optional chaining for a more concise return statement
- Enhanced readability while preserving functionality
wesleytodd
wesleytodd requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see approvals on this. We have never accepted style changes before, and I dont believe we should now. But this maybe a discussion we need to have at the TC level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd requested changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ayoub-Mabrouk @wesleytodd @UlisesGascon @bjohansebas