chore: fix tests for node 19 #475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nlf thanks for the reminder! The change is more than just a test issue, as it changes the actually way the error messages are constructed too (you'll notice the output when using the module is incorrect under Node.js 19). I started the fix on a branch with commit 495ee64 . I was testing it and it seems fine, just forgot to get it past the finish line. |
|
no worries! you're right, your commit looks good and seems to pass tests for me. this can be closed at any time. thanks @dougwilson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was a slight change in the error messaging for JSON.parse that caused some assertions to fail so i added a second parameter to alter the input we're asserting against to more appropriately match the expected error. this gets tests passing in node 19+