Skip to content

Conversation

FraSanga
Copy link
Contributor

As reported in the recurring task in this repo, I updated the tests and checked their implementation in Elixir.

Only the UUID is changed in the tests, so I believe there is nothing to do in the actual tests.

Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?

Automated comment created by PR Commenter 🤖.

@angelikatyborska
Copy link
Member

The thing that changed in the reimplemented tests are the error messages: https://github.com/exercism/problem-specifications/pull/2548/files

From "span must be smaller than string length" to "span must not exceed string length". The Elixir implementation doesn't use specific error messages, just raises a generic ArgumentError, so we don't have to change anything in the tests. Thank you!

@angelikatyborska angelikatyborska merged commit 9a543d4 into exercism:main Sep 17, 2025
9 of 10 checks passed
@FraSanga FraSanga deleted the update-largest-series-product-tests branch September 17, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants