-
-
Notifications
You must be signed in to change notification settings - Fork 404
Add new practice exercise: Camicia #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
Thanks for starting a PR to add a new exercise. I have a few questions to know how to evaluate/guide this PR:
Some exercises have a Can you give me some more information to know how to help/guide you through this process? Thanks! 💙 |
I have updated the description of the PR with the various links.
I am the author of the exercise.
It is an algorithmic exercise but does not aim at a specific concept.
I'll definitely try to take a look at it.
I'll then need some help with the definitions of practices & prerequisites in config.json. Any suggestions are welcome. 🫶 |
Sweet! Thanks for those details. I'll tag @angelikatyborska in here, as she has more familiarity with the work! |
I have created the first draft of the solution. I also ran test_exercises.sh and everything went smoothly.
From what I understand, this file serves to summarise the purpose of the exercise in Elixir. My aim, as I wrote in the proposal, is to bring as many users as possible into the world of research; even just sparking someone's curiosity would be good. I think that until you confirm the solution, there's not much point in writing the rest. |
IMO
TBH, I never care that much about the specific solution to a new practice exercise. It only exists to prove that an exercise can be solved at all, but it's not shown to students and it doesn't have to be perfect. The test suite and deciding which concepts must be known before attempting to solve the exercise (prerequisites) are much more important. I'll take a look at this PR's changes now. |
I agree. I think the prerequisites are very important. While completing the Elixir track, I would occasionally peek at the graph to see which dots were coloured in after downloading the exercise locally.
If you have any questions or requests, I am available immediately for the next two hours or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving a partial review because I ran out of time for right now. I didn't fully understand the solution yet and I didn't review "prerequisites".
(Ignore the failing link checker) |
Co-authored-by: Angelika Cathor <[email protected]>
Co-authored-by: Angelika Cathor <[email protected]>
Co-authored-by: Angelika Cathor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this exercise 🙏 I think it will be very fun for people to solve. The PR looks very good. I only left a few more nitpicks about the config and variable names. Once those are resolved, I'll approve and merge 🚀
Co-authored-by: Angelika Cathor <[email protected]>
🥳 |
Congrats on your first Elixir exercise 🥳 it's live now, so you can go ahead and publish your own solution if you want to be the first one 😁 |
There was no need to even say it, I did it as soon as I saw the notification. |
This pull request introduces a new Elixir practice exercise called
Camicia
.TO-DO: