Bugfix/fix leaking listener #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydzik
commented
Sep 4, 2017
| } | ||
|
|
||
| int callbackIndex = requestIdGenerator.generate(); | ||
| final String js = JsEvaluator.getJsForEval(jsCode, callbackIndex); |
There was a problem hiding this comment.
i kept the int as callback identifier, precision is good enough, less changes
|
Thank you very much. Do you think it is worth adding a unit test that verifies that the callback has been removed from the list? |
|
I think I did it in testJsCallFinished_runsCallbackAndRemove |
|
Yes, sorry, I missed that. All good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed leaking listener (#39) by switch to key/value structure. it was difficult on index based one
also cleaned git ignore a bit what produce bigger PR by side effect