allow load plugin result with empty loader to have null contents #3532
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a plugin that returns a `loader` value of `empty` also requires the `contents` field to be set to a non-null value for the loader to be used. Since the provided contents will never be used in the empty loader case, the `contents` field is now no longer required in the case when an `empty` loader is returned. This removes the chance of a plugin unintentionally not using the returned empty loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a plugin that returns a
loadervalue ofemptyalso requires thecontentsfield to be set to a non-null value for the loader to be used. Since the provided contents will never be used in the empty loader case, thecontentsfield is now no longer required in the case when anemptyloader is returned. This removes the chance of a plugin unintentionally not using the returned empty loader.