Skip to content

Conversation

@rjl493456442
Copy link
Member

Originally updateTrie will try to finalize the dirty storages first before trie committing. This operation is removed in this pull request, reasons as below:

  • Before the updateTrie, all the finalization has already been done in IntermediateRoot, the operation here is duplicated
  • The prefetcher has been terminated at that time and if there are some leftover slots, they will be failed for prefetching

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.14.4 milestone May 14, 2024
@holiman holiman merged commit be32843 into ethereum:master May 14, 2024
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants