Skip to content

accounts/abi: simulate detail insufficient fund for EstimateGas #28162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

accounts/abi: simulate detail insufficient fund for EstimateGas #28162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c6d721
accounts/abi: return detail insufficient error in simulate tx
jsvisa Sep 20, 2023
bc6ae28
accounts/abi: test insufficientfund
jsvisa Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions accounts/abi/bind/backends/simulated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,11 +531,11 @@ func (b *SimulatedBackend) EstimateGas(ctx context.Context, call ethereum.CallMs
if feeCap.BitLen() != 0 {
balance := b.pendingState.GetBalance(call.From) // from can't be nil
available := new(big.Int).Set(balance)
if call.Value != nil {
if call.Value.Cmp(available) >= 0 {
return 0, core.ErrInsufficientFundsForTransfer
if value := call.Value; value != nil {
if value.Cmp(available) >= 0 {
return 0, fmt.Errorf("%w: address: %s, have: %v, want: %v", core.ErrInsufficientFundsForTransfer, call.From, available, value)
}
available.Sub(available, call.Value)
available.Sub(available, value)
}
allowance := new(big.Int).Div(available, feeCap)
if allowance.IsUint64() && hi > allowance.Uint64() {
Expand Down
25 changes: 17 additions & 8 deletions accounts/abi/bind/backends/simulated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,26 +510,26 @@ func TestEstimateGas(t *testing.T) {
Data: common.Hex2Bytes("e09fface"),
}, 21275, nil, nil},
}
for _, c := range cases {
for i, c := range cases {
got, err := sim.EstimateGas(context.Background(), c.message)
if c.expectError != nil {
if err == nil {
t.Fatalf("Expect error, got nil")
t.Fatalf("test: %d expect error, got nil", i)
}
if c.expectError.Error() != err.Error() {
t.Fatalf("Expect error, want %v, got %v", c.expectError, err)
if c.expectError.Error() != err.Error() && !errors.Is(err, c.expectError) {
t.Fatalf("test: %d expect error, want %v, got %v", i, c.expectError, err)
}
if c.expectData != nil {
if err, ok := err.(*revertError); !ok {
t.Fatalf("Expect revert error, got %T", err)
t.Fatalf("test: %d expect revert error, got %T", i, err)
} else if !reflect.DeepEqual(err.ErrorData(), c.expectData) {
t.Fatalf("Error data mismatch, want %v, got %v", c.expectData, err.ErrorData())
t.Fatalf("test: %d error data mismatch, want %v, got %v", i, c.expectData, err.ErrorData())
}
}
continue
}
if got != c.expect {
t.Fatalf("Gas estimation mismatch, want %d, got %d", c.expect, got)
t.Fatalf("test: %d gas estimation mismatch, want %d, got %d", i, c.expect, got)
}
}
}
Expand Down Expand Up @@ -584,6 +584,15 @@ func TestEstimateGasWithPrice(t *testing.T) {
Data: nil,
}, 21000, errors.New("gas required exceeds allowance (10999)")}, // 10999=(2.2ether-1000wei)/(2e14)

{"EstimateWithInsufficientFund", ethereum.CallMsg{
From: addr,
To: &recipient,
Gas: 0,
GasPrice: big.NewInt(1),
Value: big.NewInt(3 * params.Ether),
Data: nil,
}, 0, core.ErrInsufficientFundsForTransfer},

{"EstimateEIP1559WithHighFees", ethereum.CallMsg{
From: addr,
To: &addr,
Expand All @@ -610,7 +619,7 @@ func TestEstimateGasWithPrice(t *testing.T) {
if err == nil {
t.Fatalf("test %d: expect error, got nil", i)
}
if c.expectError.Error() != err.Error() {
if c.expectError.Error() != err.Error() && !errors.Is(err, c.expectError) {
t.Fatalf("test %d: expect error, want %v, got %v", i, c.expectError, err)
}
continue
Expand Down