Cannot compile latest master 03585ed, fails with "undefined: atomic.Pointer" (golang1.19 required now?)

[J-A-M-E-5]

Looks like Atomic Pointer are new feature in golang1.19, which means current Ubuntu unsupported out of the box. So need to fix README which currently states "Building geth requires both a Go (version 1.18 or later)".

System information

OS & Version: Linux
Commit hash : 03585ed

Expected behaviour

Compiles. Was working a few days ago. make clean doesn't fix.

Actual behaviour

$ make geth
env GO111MODULE=on go run build/ci.go install ./cmd/geth
>>> /usr/lib/go-1.18/bin/go build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=03585ed7a932a6002569c382ab1d3b8d62819b07 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20230213 -extldflags '-Wl,-z,stack-size=0x800000'" -tags urfave_cli_no_docs -trimpath -v -o /home/jm/src/geth/build/bin/geth ./cmd/geth
github.com/ethereum/go-ethereum/eth/filters
# github.com/ethereum/go-ethereum/eth/filters
eth/filters/filter_system.go:98:14: undefined: atomic.Pointer
util.go:48: exit status 2
exit status 1
make: *** [Makefile:12: geth] Error 1

$ go version
go version go1.18.1 linux/amd64

$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.1 LTS"

$ uname -a
Linux server3 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

[Francesreid]

I don't really understand what the whole problem is , what have I done Wrong? Mrs F S Reid

[Francesreid]

HI What is the problem with the crypto, there was a report made on it , I smdont know what's going on FSReid

…

On Mon, 13 Feb 2023, 22:22 J-A-M-E-5, ***@***.***> wrote: System information OS & Version: Linux Commit hash : 03585ed <03585ed> Expected behaviour Compiles. Was working a few days ago. make clean doesn't fix. Actual behaviour $ make geth env GO111MODULE=on go run build/ci.go install ./cmd/geth >>> /usr/lib/go-1.18/bin/go build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=03585ed7a932a6002569c382ab1d3b8d62819b07 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20230213 -extldflags '-Wl,-z,stack-size=0x800000'" -tags urfave_cli_no_docs -trimpath -v -o /home/jm/src/geth/build/bin/geth ./cmd/gethgithub.com/ethereum/go-ethereum/eth/filters # github.com/ethereum/go-ethereum/eth/filters eth/filters/filter_system.go:98:14 <http://github.com/ethereum/go-ethereum/eth/filterseth/filters/filter_system.go:98:14>: undefined: atomic.Pointer util.go:48: exit status 2 exit status 1 make: *** [Makefile:12: geth] Error 1 $ go version go version go1.18.1 linux/amd64 $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=22.04 DISTRIB_CODENAME=jammy DISTRIB_DESCRIPTION="Ubuntu 22.04.1 LTS" $ uname -a Linux server3 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux — Reply to this email directly, view it on GitHub <#26679>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYKCHVZCIHMBACIEKAY2SX3WXKX2PANCNFSM6AAAAAAU22JUQY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Francesreid]

Thanks for that anyway Mrs F S Reid

…

On Mon, 13 Feb 2023, 23:19 Frances Reid, ***@***.***> wrote: HI What is the problem with the crypto, there was a report made on it , I smdont know what's going on FSReid On Mon, 13 Feb 2023, 22:22 J-A-M-E-5, ***@***.***> wrote: > System information > > OS & Version: Linux > Commit hash : 03585ed > <03585ed> > Expected behaviour > > Compiles. Was working a few days ago. make clean doesn't fix. > Actual behaviour > > $ make geth > env GO111MODULE=on go run build/ci.go install ./cmd/geth > >>> /usr/lib/go-1.18/bin/go build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=03585ed7a932a6002569c382ab1d3b8d62819b07 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20230213 -extldflags '-Wl,-z,stack-size=0x800000'" -tags urfave_cli_no_docs -trimpath -v -o /home/jm/src/geth/build/bin/geth ./cmd/gethgithub.com/ethereum/go-ethereum/eth/filters > # github.com/ethereum/go-ethereum/eth/filters > eth/filters/filter_system.go:98:14 <http://github.com/ethereum/go-ethereum/eth/filterseth/filters/filter_system.go:98:14>: undefined: atomic.Pointer > util.go:48: exit status 2 > exit status 1 > make: *** [Makefile:12: geth] Error 1 > > $ go version > go version go1.18.1 linux/amd64 > > $ cat /etc/lsb-release > DISTRIB_ID=Ubuntu > DISTRIB_RELEASE=22.04 > DISTRIB_CODENAME=jammy > DISTRIB_DESCRIPTION="Ubuntu 22.04.1 LTS" > > $ uname -a > Linux server3 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux > > — > Reply to this email directly, view it on GitHub > <#26679>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AYKCHVZCIHMBACIEKAY2SX3WXKX2PANCNFSM6AAAAAAU22JUQY> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[s1na]

I mistakenly introduced a Go v1.19 feature into the codebase thinking it was already introduced before. Please either upgrade your golang to v1.19 or use this branch as a quickfix, which reverts the commit in question: #26686

[Francesreid]

Okay thanks

…

On Tue, 14 Feb 2023, 13:41 Péter Szilágyi, ***@***.***> wrote: Closed #26679 <#26679> as completed. — Reply to this email directly, view it on GitHub <#26679 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYKCHV2OF4SUL4X7GCMLJTDWXODPLANCNFSM6AAAAAAU22JUQY> . You are receiving this because you commented.Message ID: ***@***.***>