Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

@zilm13
Copy link
Collaborator

@zilm13 zilm13 commented Jun 12, 2018

Resolves #1091
I've decided that no one should be left out and it does not cost any extra to fire more events. So I'd suggest to fire it for everything.

@zilm13 zilm13 requested a review from mkalinin June 12, 2018 21:35
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 55.912% when pulling d7a59dc on fix/ethash-listener into 144b72b on develop.

@mkalinin mkalinin merged commit cb5f167 into develop Jun 13, 2018
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zilm13 zilm13 deleted the fix/ethash-listener branch August 13, 2018 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants