This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Several fixes for FastSync #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
suggested changes
May 17, 2018
| for (Value value: dataList) { | ||
| if (value == null) continue; // Bad sign | ||
| dataListRLP.add(value.getData()); | ||
| dataListRLP.add(value.asBytes()); |
There was a problem hiding this comment.
It results in a list with not encoded elements
| needToDrop = true; | ||
| } | ||
| // Drop bad peers before creating channel | ||
| if (!needToDrop && nodeManager.getNodeStatistics(new Node(new byte[0], ch.remoteAddress().getHostString(), |
There was a problem hiding this comment.
Requesting for nodeManager.isReputationPenalized(InetSocketAddress addr) which does all the job
| if (request == null) { | ||
| long t = System.currentTimeMillis(); | ||
| logger.debug("Received node which was not requested: " + toHexString(pair.getKey()) + " from " + idle); | ||
| idle.disconnect(ReasonCode.USELESS_PEER); |
There was a problem hiding this comment.
This case could not be related to the meaning of log message standing above. It may be a result of pendingNodes purging due to REQUEST_TIMEOUT. Isn't it too rude to disconnect peer with USELESS_PEER reason in that case? Btw, log message could also be fixed to avoid misunderstanding in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyncQueueReverseImplwhich could force Fast sync to stall for a long time when it needs only to download 256 blocks