Skip to content

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jun 28, 2025

Description

  • feat: use Lucide ExternalLink for tutorial cards
  • update: use Clipboard for copy icon
  • update: upper-right/external arrows
  • update: use Lucide Languages icon
  • update: use Lucide Plus/Minus for ExpandIcon
  • fix: link icons pixel details
  • feat: migrate media icons to Lucide
  • fix: stablecoins icons (Info, ListFilter)

Preview link

https://deploy-preview-15741--ethereumorg.netlify.app/en/
https://deploy-preview-15741--ethereumorg.netlify.app/en/what-is-ethereum
https://deploy-preview-15741--ethereumorg.netlify.app/en/stablecoins

Screenshots

Media controls, Play/Pause/SkipBack/SkipForward/Minimze2/Maximize2

image image

^ One custom .svg kept in for the "autoplay" button; updated to match Lucide/stroke style

Languages

image

Copy

image

Plus/Minus

image

Main/ExternalLink sizing/positioning

image

wackerow added 7 commits June 26, 2025 18:33
rm translate.svg icon
Set mailto icon to 1em me-1 and external arrow  to 0.875em ms-1 default, each with mb-0.5 for custom pixel alignment, while remaining inline. Maz size applied of 1rem, limiting size but allowing to shrink for smaller text. Link's contained in ButtonLink are in a flex with gap, so appropriately margin override applied via `data-label='arrow'` selector. Uses inline-flex items-center, removes align-middle and bottom margins.
Copy link

netlify bot commented Jun 28, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6169023
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68670a298669830008f719cb
😎 Deploy Preview https://deploy-preview-15741--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 53 (no change from production)
Accessibility: 96 (🟢 up 2 from production)
Best Practices: 91 (🔴 down 1 from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies documentation 📖 Change or add documentation translation 🌍 This is related to our Translation Program labels Jun 28, 2025
@wackerow wackerow changed the base branch from dev to lucide June 28, 2025 18:42
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jun 28, 2025
fix: custom autoplay.svg
Base automatically changed from lucide to dev June 30, 2025 13:37
@wackerow wackerow marked this pull request as ready for review June 30, 2025 18:58
@wackerow wackerow changed the title Icon updates feat: Icon updates, Lucide icon alignment Jun 30, 2025
@wackerow wackerow requested review from nloureiro and konopkja June 30, 2025 19:29
@wackerow wackerow added the needs design approval 🧑‍🎨 Approval from a designer is needed before merging label Jun 30, 2025
@nloureiro
Copy link
Contributor

the only one feels weird is the languages one.
I know we spoke about changing it, but now that I see it on the header. Maybe it's the spacing. Closer?

In this image, I reduced the padding right to the label from 0.5 to 0.2px

Is it better? Or am I being too peaky here.
Screen Shot 2025-06-30 11 16 26 PM

@wackerow wackerow added design system this label will be used in all issues related to design system and removed content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jul 3, 2025
Fixes alignment of tooltip popups, improves alignment consistency for inline flows
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jul 3, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! like icon consistency :)

@pettinarip pettinarip merged commit 7896e7f into dev Jul 7, 2025
7 checks passed
@pettinarip pettinarip deleted the lucide-next branch July 7, 2025 08:13
This was referenced Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits design system this label will be used in all issues related to design system documentation 📖 Change or add documentation needs design approval 🧑‍🎨 Approval from a designer is needed before merging translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants