-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Description
Is your feature request related to a problem? Please describe.
With 8.7.0 a "Known issues" section was added to ERC-20 description https://ethereum.org/en/developers/docs/standards/tokens/erc-20/#erc20-issues
However, the representation looks like it is a known issue so a token developer has nothing to worry about. It mustn't look like this because the amount of damage that this issue is dealing to the ecosystem is still growing over time and if there will be no active countermeasures people will keep losing money because of this known issue.
I would propose to add two paragraphs here:
Describe the solution you'd like
- The severity of the issue must be highlighted so that devs wouldn't think that they don't need to worry about it.
- There are few ways to mitigate a significant part of potential damage that this issue can deal so this options must be proposed.
1. Highlight the severity of the issue
I would recommend to add a phrase "As of 06/20/2024 at least $83,656,418 worth of ERC-20 tokens were lost due to this issue."
We have built a script that calculates the amount of lost tokens (https://dexaran.github.io/erc20-losses/) and there are over $230M worth of lost tokens on Ethereum mainnet currently and this amount is growing every day as users keep losing tokens and those tokens that were already lost are never recovered.
My team did a due diligence on the tokens that were reported as "lost" by this script and we were able to manually verify that at least $83M worth of tokens are clearly unrecoverably lost. All the data is transparently available via Etherscan where you can observe the tokens on the balances of contracts with verified source codes that have no functions to extract these tokens.
2. Propose solution options
- The most common case is when a user is sending tokens to the address of that exact tokens smart-contract. Implementing a simple check within the logic of the
transfer
function would prevent thisrequire(address _to != address(this), "Sending to token contract");
- When deploying smart-contracts on Ethereum always assume that your contract can receive ERC-20 tokens even if it is not supposed to. It is a good practice to implement an extraction function that would allow tokens to be extracted.
- Consider using alternative standards.
Describe alternatives you've considered
It is possible to restrict the logic of transfer
function so that it wouldn't be possible to deliver tokens to smart-contracts with it but this would break backwards compatibility with some multisig wallets that are supposed to be ERC-20 compatible as well as Uniswap pools.
Additional context
No response
Would you like to work on this issue?
- Yes
- No