-
Notifications
You must be signed in to change notification settings - Fork 48
feat: operator fee scalar fix #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: operator fee scalar fix #299
Conversation
|
Could you add some additional fields to the table that make it easy to see how much USD is charged? ie an ETH/USD assumption and then a USD fee charged. This will help to make sure that the thing that impacts the end user is accounted for |
|
Do you mind calling out the parts of the codebase that will need to change? I believe no change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got good alignment on the review call. Just need to update the table and then we can merge the PR (ratify it).
This is the current operator fee formula.
The
1e-6multiplier on theoperatorFeeScalaris not useful for operators as it results in a fee that is too low to be useful. This design doc proposes the following change to the operator fee formula.With the new fee formula, here are some examples of some possible fees being charged.
For the dollar cost column, we assume an ETH price of 2.5k.
operatorFeeScalaroperatorFeeScalar * gasUsed * 100Fixes ethereum-optimism/optimism#16623