Fixed broken person_detection example (TFMIC-50)
#107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
person_detection exampleperson_detection example (TFMIC-50)
ShardulNalegave
force-pushed
the
person_detection_fix
branch
2 times, most recently
from
ca1a722 to
1edd78e
Compare
vikramdattu
reviewed
Jan 30, 2025
Yes sir, will do that once all issues/corrections are resolved. |
ShardulNalegave
force-pushed
the
person_detection_fix
branch
from
db6f4a6 to
a9c6287
Compare
|
Build fails on ESP32: |
|
I've made the required fixes, the example should build successfully now |
@ShardulNalegave the build issue was introduced in the previous commit. So, instead of adding new bugfix commit, please amend this to your original commit. |
ShardulNalegave
force-pushed
the
person_detection_fix
branch
from
246add6 to
1f0863c
Compare
|
okay sir, I've made the changes. The previous commit has now been amended instead of pushing a new bugfix commit |
|
Hi @ShardulNalegave please rebase it on latest master. This run CI for any build issues. |
- Bumped esp32_s3_eye dependency version number - Made changes to CMakeLists.txt to fix BSP packages not getting installed - Fixed issues with LVGL which caused the display to fail
ShardulNalegave
force-pushed
the
person_detection_fix
branch
from
8ff1426 to
782b3f4
Compare
|
Sure sir, done as requested. |
|
Please fix the build for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp32_s3_eyedependency version numberDescription
The
person_detectionexample is broken due to a few issues.esp32_s3_eyedependency is set to a older version (3.x) which causes errors with i2cThis PR addresses these issues.
Testing
Dependency installation related issues were testing by setting options from menuconfig and checking stdout during
idf.py buildThe complete example was tested on a ESP32 S3 Eye
Checklist
Before submitting a Pull Request, please ensure the following: