Added entry for octal flash S3 #8660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-R-O-C-H-Y
requested changes
Oct 3, 2023
Member
P-R-O-C-H-Y
left a comment
P-R-O-C-H-Y
left a comment
There was a problem hiding this comment.
@lbernstone Can you please split the parts with empty line as its done in other boards?
Member
|
@P-R-O-C-H-Y PTAL |
P-R-O-C-H-Y
reviewed
Oct 18, 2023
P-R-O-C-H-Y
approved these changes
Oct 24, 2023
P-R-O-C-H-Y
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added an entry to boards.txt for the octal flash devices. Should make it easier for people to boot S3 devices.
Tests scenarios
Tested flashing on an ESP32S3-devkitc-WROOM-2 (n32/v8)