Skip to content

Conversation

@PilnyTomas
Copy link
Contributor

Preferences:
A large block of code had lines beyond the visible edge and the reader was forced to scroll down to reach the vertical scroller, scroll up, see the hidden portion, then back down to scroll left and return to reading - this is unacceptable. I have folded those lines. Smaller blocks of code were left unchanged even when the code reached beyond the edge.
code comment

FAQ:
Added note about SPIFFS mount failed - based on "for reference" issue #638

@CLAassistant
Copy link

CLAassistant commented May 3, 2023

CLA assistant check
All committers have signed the CLA.

@PilnyTomas PilnyTomas requested a review from pedrominatel May 3, 2023 07:38
@PilnyTomas PilnyTomas self-assigned this May 3, 2023
@VojtechBartoska
Copy link
Contributor

@PilnyTomas good point, have notice this as well. Can you please rename PR name to something meaningful? Less generic. For example, "Format Update of codes blocks rendering in Documentation" or something similar. Thanks

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pedrominatel
Copy link
Member

Is there any way to check this automatically before merging? CI/Action?

@PilnyTomas PilnyTomas changed the title Doc update Updated preferences and FAQ documentation (added SPIFFS) May 9, 2023
@PilnyTomas
Copy link
Contributor Author

Is there any way to check this automatically before merging? CI/Action?

Maybe just make sure that code blocks don't exceed a certain length per line...

@me-no-dev me-no-dev merged commit a2c8920 into espressif:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants