Added methods + example to retrive local MAC for BT #7778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-R-O-C-H-Y
requested changes
Feb 1, 2023
Member
P-R-O-C-H-Y
left a comment
P-R-O-C-H-Y
left a comment
There was a problem hiding this comment.
@PilnyTomas please check my comments (typo and format issues), example is working great! Thank for the PR. After fixes it will be ready to merge.
me-no-dev
reviewed
Feb 6, 2023
| * @return The string representation of the address. | ||
| */ | ||
| std::string BTAddress::toString() const { | ||
| std::string BTAddress::toString(bool capital) const { |
Member
There was a problem hiding this comment.
I see that originally the method returns std::string, but please change it to Arduino String instead.
me-no-dev
reviewed
Feb 6, 2023
| * | ||
| * @return The BT MAC address string. | ||
| */ | ||
| std::string BluetoothSerial::getBtAddressString() { |
Member
There was a problem hiding this comment.
Same here std::string =>> String
me-no-dev
reviewed
Feb 8, 2023
| operator bool() const; | ||
| void getBtAddress(uint8_t *mac); | ||
| BTAddress getBtAddressObject(); | ||
| std::string getBtAddressString(); |
Member
There was a problem hiding this comment.
you forgot to change the type here
me-no-dev
reviewed
Feb 8, 2023
| * Every %BT device has a unique address which can be used to identify it and form connections. | ||
| */ | ||
| class BTAddress { | ||
| public: |
Member
There was a problem hiding this comment.
up in the includes, you need to change #include <string> to #include "Arduino.h"
me-no-dev
requested changes
Feb 8, 2023
Member
me-no-dev
left a comment
me-no-dev
left a comment
There was a problem hiding this comment.
Change include and left over std::string in BluetoothSerial.h
me-no-dev
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not easy or obvious how to retrieve a MAC address of a local BT device.
There is an IDF function
esp_bt_dev_get_addresswhich accomplishes that and is used in this solution.However, there was no
BluetoothSerialmethod that would facilitate this.This PR adds three new methods, slightly extends the
BTAddress::toString, and adds a new exampleGetLocalMACwhich demonstrates the usage of the new additions.