Skip to content

Conversation

@valeros
Copy link
Contributor

@valeros valeros commented Dec 12, 2022

This PR brings updates according to the latest changes in the Arduino core:

  • Bootloader binaries are now generated from elf files
  • Updated CI scripts
  • Updated esptoolpy to v4.2.1
  • Minor clean-up by removing obsolete code

Resolves #7572

@me-no-dev
Copy link
Member

@valeros ESP32-S3 does not have DIO 40MHz bootloader. It does have DIO 80MHz. In reality, default should be QIO@80MHz for all chips

@valeros
Copy link
Contributor Author

valeros commented Dec 12, 2022

Hi @me-no-dev, I'm not sure where this DIO 40MHz is coming from, we don't have any preconfigured S3-based board manifests with the DIO mode. I guess it should be fixed here https://github.com/espressif/arduino-esp32/blob/master/.github/scripts/on-push.sh#L115 with additional --project-option="board_build.flash_mode= qio" ?

@me-no-dev
Copy link
Member

@valeros it must be coming somewhere from your board definitions or build scripts, because I do not see it defined on our side as well. You can add the changes to on-push.sh for QIO and 80MHz, but it would still cause issue for users (I guess)

@Jason2866
Copy link
Collaborator

Jason2866 commented Dec 12, 2022

@valeros @me-no-dev I think this is the place where the issue is coming from https://github.com/tasmota/arduino-esp32/blob/master/.github/scripts/on-push.sh#L88
Imho a valid real boards.json should be used for the S3.
EDIT: Could be refactored at all since the S3 is supported and no hack is needed anymore.

@valeros
Copy link
Contributor Author

valeros commented Dec 12, 2022

Yeah, thanks @Jason2866 , I'm already working on renovating the action script.

This PR brings updates according to the latest changes in the Arduino core:
- Bootloader binaries are now generated from elf files
- Updated CI scripts
- Updated esptoolpy to v4.2.1
- Minor clean-up by removing obsolete code

Resolves #7572
@valeros valeros changed the title Update PlatformIO build script Update PlatformIO integration scripts Dec 12, 2022
@valeros
Copy link
Contributor Author

valeros commented Dec 12, 2022

@me-no-dev Does it look better now?

@me-no-dev
Copy link
Member

Looks good :)

@me-no-dev me-no-dev merged commit 3af0b44 into espressif:master Dec 12, 2022
@Jason2866
Copy link
Collaborator

Jason2866 commented Dec 12, 2022

@valeros Thx! Tested. Just works ;-)

@VojtechBartoska VojtechBartoska added the IDE: PlaformIO Issue relates to PlatformIO IDE label Dec 13, 2022
@valeros valeros deleted the patch-1 branch December 23, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDE: PlaformIO Issue relates to PlatformIO IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platformio broken with actual master

4 participants