Skip to content

Implement DAC based on ESP-IDF API #5959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2021
Merged

Implement DAC based on ESP-IDF API #5959

merged 2 commits into from
Dec 14, 2021

Conversation

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Dec 1, 2021

Summary

This PR is refactoring of DAC HAL in order to use IDF instead of current Register manipulation approach.

Edited dacWrite() to use ESP-IDF api.
Added dacDisable() so there is an option to disable dac channel.

Impact

None.

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev December 1, 2021 14:01
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 1, 2021
@VojtechBartoska VojtechBartoska linked an issue Dec 1, 2021 that may be closed by this pull request
Change DAC to use ESP-IDF API #5957
Closed
me-no-dev
me-no-dev reviewed Dec 14, 2021
View reviewed changes
@me-no-dev me-no-dev merged commit 39b9e1e into espressif:master Dec 14, 2021
@VojtechBartoska VojtechBartoska added this to the 2.0.2 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels

None yet

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

Change DAC to use ESP-IDF API

3 participants

@P-R-O-C-H-Y @me-no-dev @VojtechBartoska