Skip to content

fix WiFiClient::write(from flash or iram) #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2021
Merged

fix WiFiClient::write(from flash or iram) #7951

merged 2 commits into from
Apr 4, 2021

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Mar 30, 2021

WiFiClient's ClientContext was originally designed to take data from a Stream through a specific DataSource class which is now removed by the Stream::send changes.
Ability to stream from flash or dram to WiFiClient was missing from these changes, this is now restored.

Fixes #7928 (comment)

@d-a-v d-a-v added this to the 3.0.0 milestone Mar 31, 2021
@d-a-v d-a-v added the alpha included in alpha release label Mar 31, 2021
@blue-wind-25 blue-wind-25 mentioned this pull request Apr 4, 2021
Closed
@d-a-v d-a-v merged commit 1c57b34 into esp8266:master Apr 4, 2021
@d-a-v d-a-v deleted the streamsendfix2 branch April 4, 2021 09:31
@earlephilhower earlephilhower mentioned this pull request Apr 17, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devyte devyte devyte approved these changes

Assignees

No one assigned

Labels

alpha included in alpha release

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Does ESP8266WebServer and ESP8266WiFi now require non32xfer to be enabled?

2 participants

@d-a-v @devyte