Skip to content

Ignore transfer-encoding if content-length presents #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2020
Merged

Ignore transfer-encoding if content-length presents #1170

merged 3 commits into from
Aug 11, 2020

Conversation

@j178
Copy link
Contributor

@j178 j178 commented Aug 11, 2020

Closes #1168

lovelydinosaur
lovelydinosaur reviewed Aug 11, 2020
View reviewed changes
lovelydinosaur
lovelydinosaur reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor comment to resolve.

@lovelydinosaur lovelydinosaur added the bug Something isn't working label Aug 11, 2020
lovelydinosaur
lovelydinosaur approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lovelydinosaur
Copy link
Contributor

Lovely piece of work.

@j178 j178 merged commit 5b6d33e into encode:master Aug 11, 2020
@lovelydinosaur lovelydinosaur mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User-provided Content-Length header is missing from streaming requests

2 participants

@j178 @lovelydinosaur