Skip to content

Advanced transport docs, with "local_address=..." example. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2020
Merged

Advanced transport docs, with "local_address=..." example. #1165

merged 3 commits into from
Aug 11, 2020

Conversation

@lovelydinosaur
Copy link
Contributor

Related to #984
Refs encode/httpcore#100

@lovelydinosaur lovelydinosaur added the docs Changes to the documentation label Aug 11, 2020
@lovelydinosaur lovelydinosaur mentioned this pull request Aug 11, 2020
Closed
@dalf dalf mentioned this pull request Aug 11, 2020
Closed
florimondmanca
florimondmanca approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! For some reason this "Hello, World!" example conveys much better the idea that transports allow you to change what happens when the request is eventually sent. :-) Very convincing!

@lovelydinosaur lovelydinosaur mentioned this pull request Aug 11, 2020
Closed
@lovelydinosaur lovelydinosaur merged commit 477824a into master Aug 11, 2020
@lovelydinosaur lovelydinosaur deleted the advanced-transport-docs branch August 11, 2020 16:05
@lovelydinosaur lovelydinosaur mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@florimondmanca florimondmanca florimondmanca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Changes to the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lovelydinosaur @florimondmanca