Skip to content

Fix behaviour with multiple Set-Cookie headers #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fix behaviour with multiple Set-Cookie headers #1156

merged 1 commit into from
Aug 10, 2020

Conversation

@lovelydinosaur
Copy link
Contributor

Closes #1151

@lovelydinosaur lovelydinosaur added the bug Something isn't working label Aug 10, 2020
@lovelydinosaur lovelydinosaur mentioned this pull request Aug 10, 2020
Closed
florimondmanca
florimondmanca approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lovelydinosaur lovelydinosaur merged commit 4cf74bc into master Aug 10, 2020
@lovelydinosaur lovelydinosaur deleted the fix-multiple-set-cookie branch August 10, 2020 13:53
@lovelydinosaur lovelydinosaur mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@florimondmanca florimondmanca florimondmanca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Response cookies are not ingested properly in 0.14.0

2 participants

@lovelydinosaur @florimondmanca