Raise HTTPStatusError in raise_from_status #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovelydinosaur
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Looks great, yup!
I've been taking a bit of a review of the exceptions and hierarchy today, and have some thoughts on how we might refine that, and also how we might want to deal with when request= or response= should be mandatory/optional, but will treat all that separately to this.
Thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #1067. Nothing really surprising I guess:
Responsein this specific case.Happy to improve it if needed 🙂