Skip to content

Fixup bugs in README examples #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2019
Merged

Fixup bugs in README examples #7

merged 2 commits into from
Mar 6, 2019
+2 −2

Conversation

GavinJoyce
Copy link
Member

@GavinJoyce GavinJoyce commented Mar 6, 2019 •
edited
Loading

part of #2

This fixes two mistakes in the readme:

  • position params should be an array
  • element.style instead of element.css

@GavinJoyce GavinJoyce changed the title update readme: positional parameters ar an array update readme: positional parameters are an array Mar 6, 2019
@GavinJoyce GavinJoyce changed the title update readme: positional parameters are an array fix two mistakes in the readme Mar 6, 2019
rwjblue
rwjblue approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOH! thank you!

@rwjblue rwjblue merged commit 3180d09 into emberjs:master Mar 6, 2019
@GavinJoyce GavinJoyce deleted the gj/readme branch March 6, 2019 21:55
@rwjblue rwjblue changed the title fix two mistakes in the readme Fixup bugs in README examples Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GavinJoyce @rwjblue