Remove reference to global Ember API #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
May 28, 2021
* Avoid the Ember global in workflow runtime code. * Ensure the test suite isn't using deprecated API by throwing unhandled deprecations. Address several uses of deprecated Ember API. * Avoid reliance on ember-cli-babel < 7.26.6 which referenced the Ember global. * Bump ember-jquery to get emberjs/ember-jquery#321
1 task
simonihmig
approved these changes
May 28, 2021
|
I'll merge! |
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Ensure the test suite isn't using deprecated API by throwing unhandled deprecations. Address several uses of deprecated Ember API. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Ensure the test suite isn't using deprecated API by throwing unhandled deprecations. Address several uses of deprecated Ember API. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Ensure the test suite isn't using deprecated API by throwing unhandled deprecations. Address several uses of deprecated Ember API. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Ensure the test suite isn't using deprecated API by throwing unhandled deprecations. Address several uses of deprecated Ember API. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Ensure the test suite isn't using deprecated API by throwing unhandled deprecations. Address several uses of deprecated Ember API. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. * Bump ember-jquery to get emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
* Avoid the Ember global in workflow runtime code. This patch is dependent on #125 which included the code at emberjs/ember-jquery#321
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 12, 2021
* Avoid the Ember global in workflow runtime code. This patch is dependent on #125 which included the code at emberjs/ember-jquery#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid accessing the
Emberglobal which is deprecated per https://deprecations.emberjs.com/v3.x/#toc_ember-globalDiscovered working on ember-cli/ember-cli-deprecation-workflow#118