Return and show all paste warnings #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Apr 1, 2025
| @@ -129,15 +129,14 @@ namespace Terminal.Utils { | |||
| * | |||
| * @return true if safe, false if unsafe. | |||
| */ | |||
| public bool is_safe_paste (string text, out string msg) { | |||
| public bool is_safe_paste (string text, out string[]? msg_array) { | |||
There was a problem hiding this comment.
Does this need to be nullable? I don't think this ever goes to a null check. Would returning an empty array be fine?
There was a problem hiding this comment.
Just avoids unnecessarily initializing an array which is not used but an empty array could be used if you prefer.
danirabbit
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #865