Skip to content

Conversation

vhashimotoo
Copy link
Contributor

@vhashimotoo vhashimotoo commented Jul 24, 2025

Fixes #1549

This PR improves the UX of the error dialog that is showed when the user tries to perform actions (publish/update/delete) with a Gist with invalid credentials (or with some other error). This updates the dialog and adds the button that will move the user to the settings page and opens the token update window when the error is related to bad credentials and shows the standard error dialog if something else happened.

image

@vhashimotoo vhashimotoo force-pushed the vh/improve-gist-publish-error branch from fabea90 to f4a2c74 Compare July 28, 2025 19:13
@vhashimotoo vhashimotoo marked this pull request as ready for review July 28, 2025 19:13
@vhashimotoo vhashimotoo requested review from codebytere and a team as code owners July 28, 2025 19:13
@coveralls
Copy link

Coverage Status

coverage: 80.123% (-0.03%) from 80.149%
when pulling f4a2c74 on vhashimotoo:vh/improve-gist-publish-error
into 7e58cbe on electron:main.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I think we should always show an update token button for failure dialogs - there are a lot of reasons publish could fail.

@codebytere codebytere requested a review from dsanders11 July 31, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better UX for expired PAT for Gist publishing
3 participants