Skip to content

fix: Change dependency collection to parse from root #9260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2025
Merged

fix: Change dependency collection to parse from root #9260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34494fc
fix: Change dependency collection to parse from root
Julusian Aug 26, 2025
cdf8773
changeset
Julusian Aug 26, 2025
d4c6495
pr review
Julusian Aug 27, 2025
9ea3f47
Merge branch 'master' into patch-2
mmaietta Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pr-9260.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix(app-builder-lib): Change dependency collection to parse from root to better handle monorepos
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export abstract class NodeModulesCollector<T extends Dependency<T, OptionalsType

public async getNodeModules(): Promise<NodeModuleInfo[]> {
const tree: T = await this.getDependenciesTree()
this.collectAllDependencies(tree) // Parse from the root, as npm list can host and deduplicate across projects in the workspace
const realTree: T = this.getTreeFromWorkspaces(tree)
this.collectAllDependencies(realTree)
this.extractProductionDependencyGraph(realTree, "." /*root project name*/)

const hoisterResult: HoisterResult = hoist(this.transToHoisterTree(this.productionGraph), { check: true })
Expand Down
Loading