Skip to content

fix: two flaky tests #9251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2025
Merged

fix: two flaky tests #9251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e9cc77
fix: two flaky tests
daihere1993 Aug 20, 2025
aed8846
Extend getFileTypePriority() to support more artifact types and updat…
daihere1993 Aug 21, 2025
4ce21b8
1. Use an array-based approach to get file type priority
daihere1993 Aug 25, 2025
95153d5
refine code
daihere1993 Aug 25, 2025
6d3ff66
fix: failed tests
daihere1993 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
358 changes: 179 additions & 179 deletions test/snapshots/concurrentBuildsTest.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions test/snapshots/filesTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ exports[`extraResources on Linux 1`] = `
exports[`extraResources on Windows 1`] = `
{
"win": [
{
"arch": "x64",
"file": "RELEASES",
},
{
"arch": "x64",
"file": "Test App ßW Setup 1.1.0.exe",
Expand All @@ -30,6 +26,10 @@ exports[`extraResources on Windows 1`] = `
"arch": "x64",
"file": "TestApp-1.1.0-full.nupkg",
},
{
"arch": "x64",
"file": "RELEASES",
},
],
}
`;
Expand Down
8 changes: 4 additions & 4 deletions test/snapshots/linux/debTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
exports[`arm 1`] = `
{
"linux": [
{
"arch": "armv7l",
"file": "TestApp_1.1.0_armv7l.deb",
},
{
"arch": "arm64",
"file": "TestApp_1.1.0_arm64.deb",
},
{
"arch": "armv7l",
"file": "TestApp_1.1.0_armv7l.deb",
},
],
}
`;
Expand Down
8 changes: 4 additions & 4 deletions test/snapshots/linux/fpmTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ exports[`rpm and tar.gz 1`] = `
exports[`targets 1`] = `
{
"linux": [
{
"arch": "x64",
"file": "TestApp-1.1.0.zip",
},
{
"arch": "x64",
"file": "TestApp-1.1.0.7z",
Expand All @@ -34,10 +38,6 @@ exports[`targets 1`] = `
"arch": "x64",
"file": "TestApp-1.1.0.sh",
},
{
"arch": "x64",
"file": "TestApp-1.1.0.zip",
},
],
}
`;
6 changes: 3 additions & 3 deletions test/snapshots/linux/linuxArchiveTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ exports[`tar 1`] = `
"linux": [
{
"arch": "x64",
"file": "TestApp-1.1.0.tar.bz2",
"file": "TestApp-1.1.0.tar.xz",
},
{
"arch": "x64",
"file": "TestApp-1.1.0.tar.lz",
"file": "TestApp-1.1.0.tar.bz2",
},
{
"arch": "x64",
"file": "TestApp-1.1.0.tar.xz",
"file": "TestApp-1.1.0.tar.lz",
},
],
}
Expand Down
84 changes: 42 additions & 42 deletions test/snapshots/mac/dmgTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,15 @@ exports[`dmg > bundleShortVersion 1`] = `
{
"mac": [
{
"file": "Bundle-ShortVersion-2017.1-alpha5.dmg.blockmap",
"arch": "x64",
"file": "Bundle-ShortVersion-2017.1-alpha5.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Bundle-ShortVersion-2017.1-alpha5.dmg",
"file": "Bundle-ShortVersion-2017.1-alpha5.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -297,16 +297,16 @@ exports[`dmg > custom background - new way 1`] = `
{
"mac": [
{
"file": "CustomBackground-1.1.0-mac.zip.blockmap",
"safeArtifactName": "CustomBackground-1.1.0-mac.zip.blockmap",
"arch": "x64",
"file": "CustomBackground-1.1.0-mac.zip",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "CustomBackground-1.1.0-mac.zip",
"file": "CustomBackground-1.1.0-mac.zip.blockmap",
"safeArtifactName": "CustomBackground-1.1.0-mac.zip.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -367,16 +367,16 @@ exports[`dmg > disable dmg icon (light), bundleVersion 1`] = `
{
"mac": [
{
"file": "Disable-Icon-1.1.0-mac.zip.blockmap",
"safeArtifactName": "Disable-Icon-1.1.0-mac.zip.blockmap",
"arch": "x64",
"file": "Disable-Icon-1.1.0-mac.zip",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Disable-Icon-1.1.0-mac.zip",
"file": "Disable-Icon-1.1.0-mac.zip.blockmap",
"safeArtifactName": "Disable-Icon-1.1.0-mac.zip.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -437,15 +437,15 @@ exports[`dmg > dmg 1`] = `
{
"mac": [
{
"file": "Default-Dmg-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "Default-Dmg-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Default-Dmg-1.1.0.dmg",
"file": "Default-Dmg-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -564,15 +564,15 @@ exports[`dmg > license buttons config 2`] = `
{
"mac": [
{
"file": "Foo-5-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "Foo-5-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Foo-5-1.1.0.dmg",
"file": "Foo-5-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -633,15 +633,15 @@ exports[`dmg > license en 1`] = `
{
"mac": [
{
"file": "Foo-3-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "Foo-3-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Foo-3-1.1.0.dmg",
"file": "Foo-3-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -702,15 +702,15 @@ exports[`dmg > license ja 1`] = `
{
"mac": [
{
"file": "Foo-2-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "Foo-2-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Foo-2-1.1.0.dmg",
"file": "Foo-2-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -771,15 +771,15 @@ exports[`dmg > license rtf 1`] = `
{
"mac": [
{
"file": "Foo-4-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "Foo-4-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Foo-4-1.1.0.dmg",
"file": "Foo-4-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -840,15 +840,15 @@ exports[`dmg > multi language license 1`] = `
{
"mac": [
{
"file": "Foo-1-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "Foo-1-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Foo-1-1.1.0.dmg",
"file": "Foo-1-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -909,15 +909,15 @@ exports[`dmg > no background 1`] = `
{
"mac": [
{
"file": "No-Background-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "No-Background-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "No-Background-1.1.0.dmg",
"file": "No-Background-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -996,15 +996,15 @@ exports[`dmg > no build directory 2`] = `
{
"mac": [
{
"file": "NoBuildDirectory-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "NoBuildDirectory-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "NoBuildDirectory-1.1.0.dmg",
"file": "NoBuildDirectory-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -1065,16 +1065,16 @@ exports[`dmg > retina background as 2 png 1`] = `
{
"mac": [
{
"file": "RetinaBackground-1.1.0-mac.zip.blockmap",
"safeArtifactName": "RetinaBackground-1.1.0-mac.zip.blockmap",
"arch": "x64",
"file": "RetinaBackground-1.1.0-mac.zip",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "RetinaBackground-1.1.0-mac.zip",
"file": "RetinaBackground-1.1.0-mac.zip.blockmap",
"safeArtifactName": "RetinaBackground-1.1.0-mac.zip.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -1135,15 +1135,15 @@ exports[`dmg > unset dmg icon 1`] = `
{
"mac": [
{
"file": "No_Volume_Icon-1.1.0.dmg.blockmap",
"arch": "x64",
"file": "No_Volume_Icon-1.1.0.dmg",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "No_Volume_Icon-1.1.0.dmg",
"file": "No_Volume_Icon-1.1.0.dmg.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down
20 changes: 10 additions & 10 deletions test/snapshots/mac/macArchiveTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,17 @@ exports[`extraDistFiles 1`] = `
{
"mac": [
{
"file": "Test App ßW-1.1.0-mac.zip.blockmap",
"safeArtifactName": "Test App ßW-1.1.0-mac.zip.blockmap",
"arch": "x64",
"file": "Test App ßW-1.1.0-mac.zip",
"safeArtifactName": "TestApp-1.1.0-mac.zip",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Test App ßW-1.1.0-mac.zip",
"safeArtifactName": "TestApp-1.1.0-mac.zip",
"file": "Test App ßW-1.1.0-mac.zip.blockmap",
"safeArtifactName": "Test App ßW-1.1.0-mac.zip.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down Expand Up @@ -152,17 +152,17 @@ exports[`only zip 1`] = `
{
"mac": [
{
"file": "Test App ßW-1.1.0-mac.zip.blockmap",
"safeArtifactName": "Test App ßW-1.1.0-mac.zip.blockmap",
"arch": "x64",
"file": "Test App ßW-1.1.0-mac.zip",
"safeArtifactName": "TestApp-1.1.0-mac.zip",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
},
},
{
"arch": "x64",
"file": "Test App ßW-1.1.0-mac.zip",
"safeArtifactName": "TestApp-1.1.0-mac.zip",
"file": "Test App ßW-1.1.0-mac.zip.blockmap",
"safeArtifactName": "Test App ßW-1.1.0-mac.zip.blockmap",
"updateInfo": {
"sha512": "@sha512",
"size": "@size",
Expand Down
Loading
Loading