Skip to content

build wasm with expected file paths; disable optimizations when build… #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

build wasm with expected file paths; disable optimizations when build… #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
066ebc7
build wasm with expected file paths; disable optimizations when build…
May 14, 2025
739bffd
mention why no -O0
pmp-p May 14, 2025
d66c965
why change default /workspace to source path
pmp-p May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions wasm-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ else
BUILD=emscripten
if $DEBUG
then
export COPTS="-O2 -g3 --no-wasm-opt"
export LOPTS=${LOPTS:-"-O2 -g3 --no-wasm-opt -sASSERTIONS=1"}
# clang default to O0 but specifying -O0 may trigger memory start address bug in emsdk
export COPTS="-g3 --no-wasm-opt"
export LOPTS=${LOPTS:-"-g3 --no-wasm-opt -sASSERTIONS=1"}
else
# DO NOT CHANGE COPTS - optimized wasm corruption fix
export COPTS="-O2 -g3 --no-wasm-opt"
Expand Down
7 changes: 5 additions & 2 deletions wasm-build/build-with-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ IMG_TAG="17.4_3.1.61.7bi"

export WORKSPACE=${GITHUB_WORKSPACE:-$(pwd)}

# normally would default to /workspace but that may cause trouble with debug paths in some IDE
export DOCKER_WORKSPACE=${DOCKER_WORKSPACE:-$WORKSPACE}

cd $(realpath ${WORKSPACE}/postgres-pglite)

[ -f ${BUILD_CONFIG:-postgres-pglite}/.buildconfig ] && cp ${BUILD_CONFIG:-postgres-pglite}/.buildconfig .buildconfig
Expand All @@ -32,8 +35,8 @@ fi
docker run $@ \
--rm \
--env-file .buildconfig \
--workdir=/workspace \
-v ${WORKSPACE}/postgres-pglite:/workspace:rw \
--workdir=${DOCKER_WORKSPACE} \
-v ${WORKSPACE}/postgres-pglite:${DOCKER_WORKSPACE}:rw \
-v ${WORKSPACE}/postgres-pglite/dist:/tmp/sdk/dist:rw \
$IMG_NAME:$IMG_TAG \
bash --noprofile --rcfile ${SDKROOT}/wasm32-bi-emscripten-shell.sh -ci "( ./wasm-build.sh ${WHAT:-\"contrib extra\"} $PROMPT"