-
Notifications
You must be signed in to change notification settings - Fork 858
chore(workflows): run changelog
check in CI for every public package
#9041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acstll
wants to merge
5
commits into
elastic:main
Choose a base branch
from
acstll:changelog-ci-all-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💡 This check is meant to be triggered by PRs. So a possible way to test it is simply basing a new branch off this one, and making appropriate changes:
maybe some other cases worth testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, Arturo! 🟢 Thanks for doing this.
I'd wait for Tomasz to review.
This was referenced Sep 25, 2025
Co-authored-by: Weronika Olejniczak <[email protected]>
Co-authored-by: Weronika Olejniczak <[email protected]>
to clean up workflow in changelog.yml
changelog
in CI for every public packagechangelog
check in CI for every public package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the "Changelog required" workflow.
As of now, the check will pass if there's a changelog file present anywhere in
packages/*
, regardless of the number of public packages that actually contain changes. This update makes sure the check in done for every public package that has changes.For example, the check will fail with "❌ Changelog file for PR # is missing in package 'eui-theme-borealis'" if:
eui
andeui-theme-borealis
eui
Important
PR made with the help of AI, but carefully reviewed by a human (myself)
Why are we making this change?
To avoid issues while publishing packages, where a package expected to be published does not… (see #9007)
Resolves https://github.com/elastic/eui-private/issues/416
Impact to users
No impact, this is a change affecting only how the repo works.
QA
Do you know a good way to test this before actually merging? 😑