Only set window.titleBarStyle preference if different from active value
#16425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
force-pushed
the
bugfix/unnecessary-title-bar-setting
branch
from
083b1d5 to
e6a9597
Compare
colin-grant-work
changed the title
window.titleBarStyle preference if active value differswindow.titleBarStyle preference if different from active value
msujew
reviewed
Oct 13, 2025
packages/core/src/electron-browser/menu/electron-menu-contribution.ts
Outdated
Show resolved
Hide resolved
…tion.ts Extra space snuck in Co-authored-by: Mark Sujew <[email protected]>
Certainly seems that way. At a casual glance, it looks like there is some checking of the |
|
FYI my comment was just to confirm that something is broken - I can't actually test the changes, since I don't have a MacOS system available to me right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #16418 by checking whether writing the preference would be necessary.
How to test
Warning
Arguably, this 'fix' actually reveals a bug. Since the preference should not be included on MacOS, the
inspectcall should returnundefined. At the moment, it doesn't: the preference system in fact has added the preference to its schema, with the appropriate default value ofnative. We should likely fix that, and then ensure that the preference isn't active at all in that case, and that all consumers of the value correctly handle its absence.Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers