Enhance Indexer performance

[snjeza]

Fixes #4444

[rgrunber]

The zipfile part seems similar to some of the work done in #26 .

[stephan-herrmann]

We get a new warning: "At least one of the problems in category 'resource' is not analysed ... " which is indeed a bit obscure here, but what it tries to convey: @SuppressWarnings("resource") is no longer necessary (but ecj isn't 100% sure about that).

I believe the issue arises with the proposed change, because flow analysis is less sure about zip because we no longer get a fresh ZipFile on each path.

Before the change the annotation suppresses this warning:

Resource 'zip' should be managed by try-with-resource

To sum up: removing the annotation should be fine and resolve the warning

[snjeza]

To sum up: removing the annotation should be fine and resolve the warning

@stephan-herrmann I have removed it.

[stephan-herrmann]

To sum up: removing the annotation should be fine and resolve the warning

@stephan-herrmann I have removed it.

Thanks.

Unfortunately we now have a failure in org.eclipse.jdt.core.tests.model.SearchTests.testConcurrentJob.

This might be an intermittent problem, but since the changes relate to indexing, a failure in a search test could hint at a real problem. Could your changes possibly introduce some kind of race condition?

[snjeza]

Unfortunately we now have a failure in org.eclipse.jdt.core.tests.model.SearchTests.testConcurrentJob.

I can reproduce the issue. Trying to fix it.

[snjeza]

Unfortunately we now have a failure in org.eclipse.jdt.core.tests.model.SearchTests.testConcurrentJob.
This might be an intermittent problem, but since the changes relate to indexing, a failure in a search test could hint at a real problem. Could your changes possibly introduce some kind of race condition?

The test failed because of a bug in JavaModelManager.getZipFile(IPath). If a zip file has been changed, JavaModelManager won't register that change.
@stephan-herrmann I have updated the PR.